<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 3, 2017 at 10:40 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-">On Fri, Feb 3, 2017 at 10:09 PM, Sean Silva via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Feb 3, 2017 at 1:19 PM, Mikulin, Dmitry via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br></span><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span><br>
> On Feb 3, 2017, at 10:30 AM, Rafael Avila de Espindola <<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>> wrote:<br>
><br>
> Peter Collingbourne <<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>> writes:<br>
><br>
>> Does this accept "{ global: local; }”?<br>
<br>
</span>Meaning ‘a global named “local”’? Yeah, that’s a problem. We need a test case for this.<br>
I’ll fix it.<br></blockquote><div><br></div></span><div>Staring at the gold code, it seems like it treats `local` as a keyword in version scripts so this isn't an issue? You would have to write it as `"local"` or something.</div></div></div></div></blockquote><div><br></div></span><div>In LLD, we are not distinguishing quoted tokens from unquoted tokens, so the quotation marks don't work.</div></div></div></div></blockquote><div><br></div><div>It seems that there is a semantic distinction between quoted and unqoted tokens (besides this issue with treating something as a keyword or quoted name): <a href="https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gold/yyscript.y;h=e533cd3000dc10d6287cd5f569d48799d98627cb;hb=HEAD#l1068">https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gold/yyscript.y;h=e533cd3000dc10d6287cd5f569d48799d98627cb;hb=HEAD#l1068</a></div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>-- Sean Silva</div><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Dmitry.<br>
<div class="gmail-m_-4555542632531873206m_6698146028420442295m_-8436233976375923113HOEnZb"><div class="gmail-m_-4555542632531873206m_6698146028420442295m_-8436233976375923113h5"><br>
<br>
>><br>
><br>
> No, it fails.<br>
><br>
> Dimitry, can you take a look?<br>
><br>
> Cheers,<br>
> Rafael<br>
><br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></span></div><br></div></div>
<br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>