[PATCH] D28978: [ThinLTO] Add an auto-hide feature
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 2 10:17:57 PST 2017
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM with comment nit below.
================
Comment at: llvm/lib/LTO/LTO.cpp:910
+ ExportedGUIDs.count(GUID)) {
+ // We could do better by hidding when a symbol is in
+ // GUIDPreservedSymbols because it is reference from regular LTO or from
----------------
Nit: typos in comment:
s/hidding/hiding/
s/reference from/referenced from/
also maybe add "only" before "referenced from" to clarify.
https://reviews.llvm.org/D28978
More information about the llvm-commits
mailing list