[PATCH] D28978: [ThinLTO] Add an auto-hide feature

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 10:04:17 PST 2017


mehdi_amini marked an inline comment as done.
mehdi_amini added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:910
+          ExportedGUIDs.count(GUID)) {
+        if (GUIDPreservedSymbols.count(GUID))
+          return Exported;
----------------
tejohnson wrote:
> Add TODO about distinguishing which are used in regular LTO partition vs outside LTO/IR.
After discussing with Peter, we believe this is something the native linker could do.

What is not done in the current patch but can help (a little) the Codegen is to propagate the `FinalDefinitionInLinkageUnit`, to every uses to skip the GOT.


https://reviews.llvm.org/D28978





More information about the llvm-commits mailing list