[PATCH] D29374: [libFuzzer] cmd prompt doesn't expand wildcard.

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

The meaning of `REQUIRES: shell` is not intuitive, but it does not mean "I have the ability to run shell commands".  See this thread for more details: http://lists.llvm.org/pipermail/llvm-dev/2016-August/103713.html

TL;DR is that even if `REQUIRES: shell` would be false (as it would on Windows), this test is still guaranteed to work on Windows.  Using `ls` and `xargs` does not mean we need to add `REQUIRES: shell`.  GnuWin32 (which provides windows implementations of commands such as `ls` and `xargs`) is guaranteed to be present on Windows because it is a required dependency.

Another option I can think of is to build wildcard expansion functionality into lit, but this is probably beyond the scope of this patch and would likely require lots of agreement and buy-in from various people in the community.


https://reviews.llvm.org/D29374