[PATCH] D29309: [PM] Add support for instrumented PGO in the new pass manager (clang-side)

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 11:17:10 PST 2017


I am fine with whatever that is a common practice.

David

On Tue, Jan 31, 2017 at 11:08 AM, Davide Italiano via Phabricator <
reviews at reviews.llvm.org> wrote:

> davide added inline comments.
>
>
> ================
> Comment at: lib/CodeGen/BackendUtil.cpp:805
> +    else
> +      PB.ProfileGenFile = "default_%m.profraw";
> +  }
> ----------------
> davidxl wrote:
> > can you define a macro for the default profile file name to be shared?
> Sure thing. I generally prefer a global `const std::string` (trying to
> avoid macros), is that the same to you?
>
>
> https://reviews.llvm.org/D29309
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170131/9903953b/attachment.html>


More information about the llvm-commits mailing list