<div dir="ltr">I am fine with whatever that is a common practice.<div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 31, 2017 at 11:08 AM, Davide Italiano via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">davide added inline comments.<br>
<span class=""><br>
<br>
================<br>
Comment at: lib/CodeGen/BackendUtil.cpp:<wbr>805<br>
</span><span class="">+    else<br>
+      PB.ProfileGenFile = "default_%m.profraw";<br>
+  }<br>
</span>----------------<br>
<span class="">davidxl wrote:<br>
> can you define a macro for the default profile file name to be shared?<br>
</span>Sure thing. I generally prefer a global `const std::string` (trying to avoid macros), is that the same to you?<br>
<br>
<br>
<a href="https://reviews.llvm.org/D29309" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D29309</a><br>
<br>
<br>
<br>
</blockquote></div><br></div>