[PATCH] D29299: [X86][Tablegen] Fixing register defs and uses for the ENTER instruction.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 30 17:08:07 PST 2017
craig.topper added inline comments.
================
Comment at: lib/Target/X86/X86InstrInfo.td:1080
// Constructing a stack frame.
-def ENTER : Ii16<0xC8, RawFrmImm8, (outs), (ins i16imm:$len, i8imm:$lvl),
- "enter\t$len, $lvl", [], IIC_ENTER>, Sched<[WriteMicrocoded]>;
+let Defs = [EBP, ESP], Uses = [EBP, ESP], mayLoad = 1, hasSideEffects=0 in
+def ENTER : Ii16<0xC8, RawFrmImm8, (outs), (ins i16imm:$len, i8imm:$lvl),
----------------
Why mayLoad? Shouldn't it be mayStore?
Repository:
rL LLVM
https://reviews.llvm.org/D29299
More information about the llvm-commits
mailing list