[PATCH] D28675: [DAGCombine] require UnsafeFPMath for re-association of addition

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 13:38:58 PST 2017


hfinkel added a comment.

In https://reviews.llvm.org/D28675#659129, @nhaehnle wrote:

> In https://reviews.llvm.org/D28675#659120, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D28675#659097, @nhaehnle wrote:
> >
> > > Yeah, I personally feel more comfortable having the exact same change on the branch.
> >
> >
> > I meant that having getFlags() always return something dereferenceable seems safer.
>
>
> Aha, I misunderstood. It's still not clear what those two comments mean together :)
>
> Do you strongly prefer a very limited fix, meaning that looking at getFlags() is postponed for whoever gets around to supporting those on FMA(D) when they do? Either way, the FIXME stays (maybe rephrased).


I'm not sure how strongly I feel about it, but I think it is better to save that until we make it work. That way we can make sure we get test cases for it at the time. That seems better than adding dead code.


https://reviews.llvm.org/D28675





More information about the llvm-commits mailing list