[PATCH] D28675: [DAGCombine] require UnsafeFPMath for re-association of addition

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

In https://reviews.llvm.org/D28675#659120, @hfinkel wrote:

> In https://reviews.llvm.org/D28675#659097, @nhaehnle wrote:
>
> > Yeah, I personally feel more comfortable having the exact same change on the branch.
>
>
> I meant that having getFlags() always return something dereferenceable seems safer.


Aha, I misunderstood. It's still not clear what those two comments mean together :)

Do you strongly prefer a very limited fix, meaning that looking at getFlags() is postponed for whoever gets around to supporting those on FMA(D) when they do? Either way, the FIXME stays (maybe rephrased).


https://reviews.llvm.org/D28675