[PATCH] D29185: Allow llvm's build and test systems to support paths with spaces

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 07:31:20 PST 2017


bd1976llvm added inline comments.


================
Comment at: utils/lit/lit/TestRunner.py:731
+
+    # "%:[STpst]" are escaped paths without colons.
+    if kIsWindows:
----------------
rnk wrote:
> I can't find any tests using these substitutions. Any reason not to remove them? At least don't add %^:s without a clear use case for it.
I wanted to add %^ versions for all of the existing substitutions so that the ability to cope with spaces in paths is available. I actually can't find any tests using the %:[sSptT] substitutions. Do you think that I can remove these. If out of tree tools need them they can add them to local lit config files.


https://reviews.llvm.org/D29185





More information about the llvm-commits mailing list