[PATCH] D29185: Allow llvm's build and test systems to support paths with spaces

[ben via Phabricator via llvm-commits]

bd1976llvm added inline comments.


================
Comment at: test/lit.cfg:334
         tool_path = llvm_tools_dir + '/' + tool_name
-    config.substitutions.append((pattern, tool_pipe + tool_path))
+    config.substitutions.append((pattern, tool_pipe + lit.util.escapeSpaces(tool_path)))
 
----------------
MatzeB wrote:
> Escaping spaces is probably a first step, but wouldn't we rather need a (posix?) shell escape mechanism? (maybe python shlex.quote/pipes.quote?)
We don't need one right now. Why not accept this as an improvement and leave the implementation of a more general escaping mechanism for when/if it is required in the future?


https://reviews.llvm.org/D29185