[PATCH] D29219: [AArch64][TableGen] Skip tied result operands for InstAlias

[Graham Hunter via Phabricator via llvm-commits]

huntergr added a comment.

In https://reviews.llvm.org/D29219#658698, @rengolin wrote:

> Hi Graham,
>
> This looks ok to me, but I'm not confident to approve a TableGen back-end patch that could potentially change the behaviour in other targets.
>
> I'm adding other people that touched the code / table files recently, and I'm hoping that other targets developers got the mail via the commits list and will chime in if necessary.
>
> cheers,
> --renato


Thanks for looking over it.



================
Comment at: lib/Target/AArch64/AArch64InstrInfo.td:455
 // First group of aliases covers an implicit "lsl #0".
-def : InstAlias<"movk $dst, $imm", (MOVKWi GPR32:$dst, imm0_65535:$imm, 0)>;
-def : InstAlias<"movk $dst, $imm", (MOVKXi GPR64:$dst, imm0_65535:$imm, 0)>;
+def : InstAlias<"movk $dst, $imm", (MOVKWi GPR32:$dst, imm0_65535:$imm, 0), 0>;
+def : InstAlias<"movk $dst, $imm", (MOVKXi GPR64:$dst, imm0_65535:$imm, 0), 0>;
----------------
rengolin wrote:
> If I read `Target.td` correctly, this completely disables the printing in all cases, not just the one you're testing.
That's my understanding as well. In this case, imm0_65535 printed in hex, whereas the unit tests are in decimal. The alternative is to change the tests to expect hex.


https://reviews.llvm.org/D29219