[PATCH] D29121: [Docs] Add LangRef documention for freeze instruction

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 06:18:04 PST 2017


filcab added a comment.

Please check the inconsistent quoting of keywords (which we already have in LangRef, but no need adding to it). Otherwise, no more nitpicking on my side :-)
Thanks.



================
Comment at: LangRef.rst:5420
 to the '``iffalse``' ``label`` argument.
+If "cond" is either ``undef`` or ``poison``, this instruction has
+undefined behavior.
----------------
```
'``cond``'
```?
And maybe quote both undef and poison.


================
Comment at: LangRef.rst:5472
 to the default destination.
+If "value" is either ``undef`` or ``poison``, this instruction has
+undefined behavior.
----------------
Inconsistent quoting here too.


================
Comment at: LangRef.rst:5539
+If "address" is either ``undef`` or ``poison``, this instruction has
+undefined behavior.
 
----------------
And here.


https://reviews.llvm.org/D29121





More information about the llvm-commits mailing list