[PATCH] D27986: Print numeric section flag for OS/processor specific bits

[Christof Douma via Phabricator via llvm-commits]

christof added a comment.

Hi Phrakar.  I think you mean that there are no processor or OS specific flags with textual representation. But yes, SHF_ARM_PURECODE is the first of its kind. Makes me wonder if we are better of not having a textual representation at all for the flag.



================
Comment at: lib/MC/MCSectionELF.cpp:95
+  // flag, otherwise use the symbolic representation
+  if (Flags & (ELF::SHF_MASKOS | ELF::SHF_MASKPROC))
+    OS << format_hex(Flags, 0);
----------------
I believe that the right style is to give the whole if-else has curly braces ("{", "}") or none. Since you need it at the else clause, you have to add it here as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D27986