D28094: [ELF] - Implemented support for R_386_PC8/R_386_8 relocations.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 01:19:14 PST 2017


>>But we already have the same assignment in X86_64TargetInfo<ELFT>::relocateOne, so I guess we've accepted that?

>
>I guess that means we are not compiling LLD with this and probably other useful warnings.
>Type conversion warnings can be useful for static analysis and I would fix that place too instead of accepting.
>
>George.


By the way, found we have next code in linkerscript.cpp


template <class ELFT>
static void writeInt(uint8_t *Buf, uint64_t Data, uint64_t Size) {
  const endianness E = ELFT::TargetEndianness;

  switch (Size) {
  case 1:
    *Buf = (uint8_t)Data;?

?George.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170127/dc20e2f5/attachment.html>


More information about the llvm-commits mailing list