<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p><span style="font-size: 12pt; color: rgb(33, 33, 33);">>>But we already have the same assignment in </span><span style="font-size: 12pt; color: rgb(33, 33, 33);">X86_64TargetInfo<ELFT>::relocateOne</span><span style="font-size: 12pt; color: rgb(33, 33, 33);">,
so I guess we've accepted that?</span><br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<div>
<div style="color:rgb(33,33,33)">
<div>
<div class="gmail_extra">><br>
<div class="gmail_quote">>I guess that means we are not compiling LLD with this and probably other useful warnings.<br>
</div>
<span style="font-size:12pt">>Type conversion warnings can be useful for static analysis and I would fix that place too instead of accepting.</span></div>
<div class="gmail_extra"><span style="font-size:12pt">> </span></div>
<div class="gmail_extra"><span style="font-size:12pt">>George.</span></div>
<div class="gmail_extra"><span style="font-size:12pt"><br>
</span></div>
<div class="gmail_extra">
<p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">By the way, found we have next code in linkerscript.cpp<br>
</p>
<p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;"><br>
</p>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
template <class ELFT></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
static void writeInt(uint8_t *Buf, uint64_t Data, uint64_t Size) {</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
const endianness E = ELFT::TargetEndianness;</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
switch (Size) {</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
case 1:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">
*Buf = (uint8_t)Data;<br>
</div>
<div><br>
George.<br>
</div>
<span style="font-size:12pt"><br>
</span></div>
</div>
</div>
</div>
</div>
</body>
</html>