[PATCH] D29047: Introduce a basic MemorySSA updater, that supports insertDef and insertUse operations.

[Daniel Berlin via llvm-commits]

The #if 0 will definitely go away, it's pending my followup patch to add
moveBefore

On Thu, Jan 26, 2017 at 1:31 PM, Davide Italiano via Phabricator <
reviews at reviews.llvm.org> wrote:

> davide added a comment.
>
> I spent a bit of time reviewing this (with particular attention to the
> marker algorithm) and I think it's correct. Minor comments inline, happy to
> see this in when George is happy with it.
>
>
>
> ================
> Comment at: include/llvm/Transforms/Utils/MemorySSA.h:741-742
>
> +class MemorySSAUpdater {
> +private:
> +  MemorySSA *MSSA;
> ----------------
> This is just my personal preference, so ignore it if you don't like, but,
> what about moving the updater to its own separate file?
>
>
> ================
> Comment at: unittests/Transforms/Utils/MemorySSA.cpp:671
>
> +#if 0
>  // Test out MemorySSA::spliceMemoryAccessAbove.
> ----------------
> I assume this `#if 0` will go away, right?
>
>
> https://reviews.llvm.org/D29047
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170126/d7ac224b/attachment-0001.html>