[PATCH] D29047: Introduce a basic MemorySSA updater, that supports insertDef and insertUse operations.

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

I spent a bit of time reviewing this (with particular attention to the marker algorithm) and I think it's correct. Minor comments inline, happy to see this in when George is happy with it.



================
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:741-742
 
+class MemorySSAUpdater {
+private:
+  MemorySSA *MSSA;
----------------
This is just my personal preference, so ignore it if you don't like, but, what about moving the updater to its own separate file?


================
Comment at: unittests/Transforms/Utils/MemorySSA.cpp:671
 
+#if 0
 // Test out MemorySSA::spliceMemoryAccessAbove.
----------------
I assume this `#if 0` will go away, right?


https://reviews.llvm.org/D29047