[PATCH] D29185: Allow llvm's build and test systems to support paths with spaces

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

Would it make sense to split this into

- cmake changes (look good to me)
- test changes (they all look good to me)
- lit changes (I have to find more time to read/think about those)
- bash script changes (they look good to me)



================
Comment at: test/lit.cfg:334
         tool_path = llvm_tools_dir + '/' + tool_name
-    config.substitutions.append((pattern, tool_pipe + tool_path))
+    config.substitutions.append((pattern, tool_pipe + lit.util.escapeSpaces(tool_path)))
 
----------------
Escaping spaces is probably a first step, but wouldn't we rather need a (posix?) shell escape mechanism? (maybe python shlex.quote/pipes.quote?)


https://reviews.llvm.org/D29185