[PATCH] D29185: Allow llvm's build and test systems to support paths with spaces

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 26 11:05:33 PST 2017


MatzeB added a comment.

I trust that this patch fixes the issues we have today and that bugpoint issue really should be fixed.

On the other hand I am not sure we will be able to keep this working consistently in a project with hundreds of comitters. So maybe we should just make our life easier and declare this an unsupported configuration. I would propose to add this to our toplevel CMakeLists.txt:

  if(CMAKE_SOURCE_DIR MATCHES " " OR CMAKE_BINARY_DIR MATCHES " ")
    message(WARNING "Spaces in the path to the source or build directory are"
    " supported on a best-effort basis. We recommend to use paths without spaces.")
  endif()


https://reviews.llvm.org/D29185





More information about the llvm-commits mailing list