[PATCH] D28152: Cortex-A57 scheduling model for ARM backend (AArch32)

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

In https://reviews.llvm.org/D28152#652694, @rengolin wrote:

> In https://reviews.llvm.org/D28152#652690, @andrew.zhogin wrote:
>
> > No, I don't have access to Cortex-A57 system. Maybe, you can recommend some hosting with such processors?
>
>
> I don't know many cloud / hosting services, maybe someone else can chime in.
>
> @kristof.beyls, do you have infrastructure to benchmark AArch32 on A57?
>
> cheers,
> --renato


@andrew.zhogin : I tried to measure the impact of this patch on performance on a Cortex-A57 system, but with this patch, testing in Thumb mode, the cmake-based test-suite runs fail early during the configuration step, with the following error:

  -- Check size of unsigned long - failed
  CMake Error at /usr/share/cmake-3.5/Modules/TestBigEndian.cmake:51 (message):
    no suitable type found
  Call Stack (most recent call first):
    CMakeLists.txt:115 (test_big_endian)

This doesn't happen when testing in ARM mode, or when testing without your patch applied.
I tested on r292764.
Could you try and see if you could reproduce this?
The lnt runtest test-suite command line I used looks as follows:

  lnt runtest test-suite --sandbox SANDBOX --no-timestamp --test-suite /work/llvm-test-suite --benchmarking-only --cppflags '-O3 -DNDEBUG -mcpu=cortex-a57 -mthumb -fomit-frame-pointer ' --threads 1 --build-threads 6 --use-perf time --use-lit lit --exec-multisample 1 --only-test=SingleSource/Benchmarks --cmake-define 'CMAKE_C_FLAGS_RELEASE=""' --cmake-define 'CMAKE_CXX_FLAGS_RELEASE=""'

Thanks,

Kristof


https://reviews.llvm.org/D28152