[llvm] r292798 - Post-commit review feedback from dblaikie

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 08:49:35 PST 2017


Author: cbieneman
Date: Mon Jan 23 10:49:34 2017
New Revision: 292798

URL: http://llvm.org/viewvc/llvm-project?rev=292798&view=rev
Log:
Post-commit review feedback from dblaikie

Use ASSERT_* instead of EXPECT_* for error condition.

Modified:
    llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

Modified: llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp?rev=292798&r1=292797&r2=292798&view=diff
==============================================================================
--- llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp (original)
+++ llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp Mon Jan 23 10:49:34 2017
@@ -1177,7 +1177,7 @@ TEST(DWARFDebugInfo, TestEmptyChildren)
                          "        Values:\n";
 
   auto ErrOrSections = DWARFYAML::EmitDebugSections(StringRef(yamldata));
-  EXPECT_TRUE((bool)ErrOrSections);
+  ASSERT_TRUE((bool)ErrOrSections);
 
   auto &DebugSections = *ErrOrSections;
 




More information about the llvm-commits mailing list