[PATCH] D29050: [zorg] Add AOSP builder

[Tobias Grosser via Phabricator via llvm-commits]

grosser added inline comments.


================
Comment at: zorg/buildbot/builders/AOSPBuilder.py:84
+                           description=["install llvm"],
+                           workdir=llvm_objdir))
+
----------------
pzheng wrote:
> grosser wrote:
> > Why do you need to list these steps again? Can you not just use include the normal Polly bullder (that you recently extended to allow the installation of clang)?
> These steps are included in getPollyBuildFactory, but can not be directly used here since getPollyBuildFactory returns a BuildFactory. We can certainly do some refactoring of the code in PollyBuilder.py to make some of the code reusable by both the Polly Builder and AOSP Builder if that makes more sense to you.
Why can you not just add more steps to the BuildFactory returned by getPollyBuildFactory.

getPollyLNTFactory() does this. It uses a function addLNTTestsToFactory, but as we add only steps at the end, this might not even be needed. And yes, I think avoiding code duplication makes sense here.


https://reviews.llvm.org/D29050