[PATCH] D29050: [zorg] Add AOSP builder

Pengxuan Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 22:39:51 PST 2017


pzheng added inline comments.


================
Comment at: zorg/buildbot/builders/AOSPBuilder.py:84
+                           description=["install llvm"],
+                           workdir=llvm_objdir))
+
----------------
grosser wrote:
> Why do you need to list these steps again? Can you not just use include the normal Polly bullder (that you recently extended to allow the installation of clang)?
These steps are included in getPollyBuildFactory, but can not be directly used here since getPollyBuildFactory returns a BuildFactory. We can certainly do some refactoring of the code in PollyBuilder.py to make some of the code reusable by both the Polly Builder and AOSP Builder if that makes more sense to you.


https://reviews.llvm.org/D29050





More information about the llvm-commits mailing list