[PATCH] D29068: AMDGPU/SI: Move some ISel helpers into utils so they can be shared with GISel

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:2536-2550
+int64_t SIInstrInfo::getSMRDEncodedOffset(const AMDGPUSubtarget &ST,
+                                          int64_t ByteOffset) {
+  if (ST.getGeneration() < AMDGPUSubtarget::VOLCANIC_ISLANDS)
+    return ByteOffset >> 2;
+
+  return ByteOffset;
+}
----------------
tstellarAMD wrote:
> arsenm wrote:
> > These are trivial enough to go in the header
> I tried this, but it would require including AMDGPUSubtarget.h in SIInstrInfo.h which creates a circular header dependency.
It would also make sense to mote into AMDGPUBaseInfo since it is encoding related


https://reviews.llvm.org/D29068