[PATCH] D29068: AMDGPU/SI: Move some ISel helpers into utils so they can be shared with GISel

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 18:56:43 PST 2017


tstellarAMD added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:2536-2550
+int64_t SIInstrInfo::getSMRDEncodedOffset(const AMDGPUSubtarget &ST,
+                                          int64_t ByteOffset) {
+  if (ST.getGeneration() < AMDGPUSubtarget::VOLCANIC_ISLANDS)
+    return ByteOffset >> 2;
+
+  return ByteOffset;
+}
----------------
arsenm wrote:
> These are trivial enough to go in the header
I tried this, but it would require including AMDGPUSubtarget.h in SIInstrInfo.h which creates a circular header dependency.


https://reviews.llvm.org/D29068





More information about the llvm-commits mailing list