Comment for EXTRACT_VECTOR_ELT

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 05:14:21 PST 2017


>>
>>
>>> Hi,
>>>
>>> I would like to see the comment for EXTRACT_VECTOR_ELT in 
>>> ISDOpcodes.h clarified. Is my patch correct in assuming that an 
>>> any-extend is allowed?
>
> Given that it says just 'extended' currently, without specifying how, 
> I don't see how the proposed wording is semantically different. If you 
> want to make this clearer, you'll need to say explicitly that the high 
> bits are undefined.
>
>  -Hal

I was kind of expecting to have the extend operation explicitly 
described, although I certainly also would guess 'any-ext'. I am fine 
with your wording as well -- see attachement. Is it ok? /Jonas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: EXTR_VEC_ELT_COMMENT.2.patch
Type: text/x-patch
Size: 751 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170124/973524f8/attachment.bin>


More information about the llvm-commits mailing list