Comment for EXTRACT_VECTOR_ELT

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 03:29:18 PST 2017



On 01/24/2017 12:03 AM, Jonas Paulsson via llvm-commits wrote:
> ping!
>
>
> On 2017-01-16 16:51, Jonas Paulsson wrote:
>> Hi,
>>
>> I would like to see the comment for EXTRACT_VECTOR_ELT in 
>> ISDOpcodes.h clarified. Is my patch correct in assuming that an 
>> any-extend is allowed?

Given that it says just 'extended' currently, without specifying how, I 
don't see how the proposed wording is semantically different. If you 
want to make this clearer, you'll need to say explicitly that the high 
bits are undefined.

  -Hal

>>
>> /Jonas
>>
>> diff --git a/include/llvm/CodeGen/ISDOpcodes.h 
>> b/include/llvm/CodeGen/ISDOpcodes.h
>> index df700bf..87207ee 100644
>> --- a/include/llvm/CodeGen/ISDOpcodes.h
>> +++ b/include/llvm/CodeGen/ISDOpcodes.h
>> @@ -281,7 +281,7 @@ namespace ISD {
>>      /// EXTRACT_VECTOR_ELT(VECTOR, IDX) - Returns a single element 
>> from VECTOR
>>      /// identified by the (potentially variable) element number 
>> IDX.  If the
>>      /// return type is an integer type larger than the element type 
>> of the
>> -    /// vector, the result is extended to the width of the return type.
>> +    /// vector, the result is any-extended to the width of the 
>> return type.
>>      EXTRACT_VECTOR_ELT,
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list