[PATCH] D28848: [PM] Teach LoopUnroll to update the LPM infrastructure as it unrolls loops.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 22:11:31 PST 2017


chandlerc marked 2 inline comments as done.
chandlerc added a comment.

Thanks, both addressed!



================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:116-125
 
+static cl::opt<bool> UnrollRevisitChildLoops(
+    "unroll-revisit-child-loops", cl::Hidden,
+    cl::desc("This tells the unroller to enqueue child loops in the loop pass "
+             "manager to be re-visited after unrolling. Typically, this "
+             "shouldn't be needed as child loops were already visited (or the "
+             "child loop they are cloned from was already visited). This "
----------------
davide wrote:
> This is a little verbose (maybe part of this can be moved to a comment? (up to you, I don't feel strong about it).
Nah, it was wordy. Thanks for the suggestion. I both tightened it up and moved part of it to a comment.


https://reviews.llvm.org/D28848





More information about the llvm-commits mailing list