[PATCH] D28848: [PM] Teach LoopUnroll to update the LPM infrastructure as it unrolls loops.

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:116-125
 
+static cl::opt<bool> UnrollRevisitChildLoops(
+    "unroll-revisit-child-loops", cl::Hidden,
+    cl::desc("This tells the unroller to enqueue child loops in the loop pass "
+             "manager to be re-visited after unrolling. Typically, this "
+             "shouldn't be needed as child loops were already visited (or the "
+             "child loop they are cloned from was already visited). This "
----------------
This is a little verbose (maybe part of this can be moved to a comment? (up to you, I don't feel strong about it).


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:1157-1159
+  // The parent must not be damaged by unrolling!
+  if (ParentL)
+    ParentL->verifyLoop();
----------------
`#ifdef NDEBUG`, maybe ?


https://reviews.llvm.org/D28848