[llvm] r292623 - [AMDGPU] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).
Eugene Zelenko via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 23 15:55:36 PST 2017
Hi, Malcolm!
On Mon, Jan 23, 2017 at 4:17 AM, Malcolm Parsons
<malcolm.parsons at gmail.com> wrote:
> On 20 January 2017 at 17:52, Eugene Zelenko via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> // Fixed SGPR number used to hold wave scratch offset for entire kernel
>> // execution, or uint16_t(-1) if the register is not used or not known.
>> - uint16_t DebuggerWavefrontPrivateSegmentOffsetSGPR;
>> + uint16_t DebuggerWavefrontPrivateSegmentOffsetSGPR =
>> + std::numeric_limits<uint16_t>::max();
>
> Update the comment?
>
>> // Fixed SGPR number of the first 4 SGPRs used to hold scratch V# for entire
>> // kernel execution, or uint16_t(-1) if the register is not used or not
>> // known.
>> - uint16_t DebuggerPrivateSegmentBufferSGPR;
>> + uint16_t DebuggerPrivateSegmentBufferSGPR =
>> + std::numeric_limits<uint16_t>::max();
>
> Same here.
>
> --
> Malcolm Parsons
Thank you for spotting problem! Fixed in r292853.
Eugene.
More information about the llvm-commits
mailing list