[llvm] r292623 - [AMDGPU] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Malcolm Parsons via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 04:17:13 PST 2017


On 20 January 2017 at 17:52, Eugene Zelenko via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>      // Fixed SGPR number used to hold wave scratch offset for entire kernel
>      // execution, or uint16_t(-1) if the register is not used or not known.
> -    uint16_t DebuggerWavefrontPrivateSegmentOffsetSGPR;
> +    uint16_t DebuggerWavefrontPrivateSegmentOffsetSGPR =
> +        std::numeric_limits<uint16_t>::max();

Update the comment?

>      // Fixed SGPR number of the first 4 SGPRs used to hold scratch V# for entire
>      // kernel execution, or uint16_t(-1) if the register is not used or not
>      // known.
> -    uint16_t DebuggerPrivateSegmentBufferSGPR;
> +    uint16_t DebuggerPrivateSegmentBufferSGPR =
> +        std::numeric_limits<uint16_t>::max();

Same here.

-- 
Malcolm Parsons


More information about the llvm-commits mailing list