[PATCH] D28947: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: test/CodeGen/AArch64/xray-tail-call-sled.ll:29
+; CHECK-NEXT:  ret
+}
+
----------------
rSerge wrote:
> dberris wrote:
> > You probably want to make sure that you have the instrumentation map for this function and the one below.
> I thought about this, but this is already tested in `llvm\test\CodeGen\AArch64\xray-attribute-instrumentation.ll`. Why to duplicate here the testing of instrumentation map emission?
That's fair -- I was thinking about the off-chance that maybe the tail sled's entry is not emitted as part of the table (or that it has a different type). Adding a test specifically for the tail sled's entry in the map with the correct type gets us coverage to make sure we don't break that part again.


https://reviews.llvm.org/D28947