[PATCH] D28947: [XRay][AArch64] More staging for tail call support in XRay on AArch64 - in LLVM

Serge Rogatch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 06:46:51 PST 2017


rSerge added inline comments.


================
Comment at: test/CodeGen/AArch64/xray-tail-call-sled.ll:29
+; CHECK-NEXT:  ret
+}
+
----------------
dberris wrote:
> You probably want to make sure that you have the instrumentation map for this function and the one below.
I thought about this, but this is already tested in `llvm\test\CodeGen\AArch64\xray-attribute-instrumentation.ll`. Why to duplicate here the testing of instrumentation map emission?


https://reviews.llvm.org/D28947





More information about the llvm-commits mailing list