[PATCH] D29021: [ELF] - Stop handling local symbols in a special way.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 06:09:43 PST 2017


George Rimar <grimar at accesssoftek.com> writes:

>>> -    P->setSymbolAndType(Body.DynsymIndex, Type, Config->Mips64EL);
>>> +    P->setSymbolAndType(In<ELFT>::SymTab->getSymbolIndex(&Body), Type,
>>> +                        Config->Mips64EL);
>>
>>This is scary. It now does a scan over all symbol to find the
>>index. Have you benchmarked this?
>>
>>Cheers,
>>Rafael
>
> Nope, but that is only for -relocatable, I think perfomance is the same as D28773, 
> but anyways supposed next optimization should go in a following patch:

Sorry, I missed that. Taking another look.

Cheers,
Rafeal


More information about the llvm-commits mailing list