[PATCH] D29021: [ELF] - Stop handling local symbols in a special way.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 06:06:52 PST 2017


>> -    P->setSymbolAndType(Body.DynsymIndex, Type, Config->Mips64EL);
>> +    P->setSymbolAndType(In<ELFT>::SymTab->getSymbolIndex(&Body), Type,
>> +                        Config->Mips64EL);
>
>This is scary. It now does a scan over all symbol to find the
>index. Have you benchmarked this?
>
>Cheers,
>Rafael

Nope, but that is only for -relocatable, I think perfomance is the same as D28773, 
but anyways supposed next optimization should go in a following patch:

A In<ELFT>::SymTab can have some map from Body->symbol index and all what needed is 
to reimplement getSymbolIndex() to search in that map.

I can do that in this patch if general idea is ok.

Best regards,
George.


More information about the llvm-commits mailing list