[PATCH] D28949: [InstCombine][SSE] Add support for PACKSS/PACKUS constant folding

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 22 06:20:51 PST 2017


RKSimon added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:539
+  auto *Cst1 = dyn_cast<Constant>(Arg1);
+  if (Cst0 && Cst1) {
+    SmallVector<Constant *, 32> Vals;
----------------
craig.topper wrote:
> Can you reverse this if as an early out?
Sure - I was hoping to extend this at some point to support non-constant cases where saturation won't happen (and can be safely converted to a shuffle + truncate) but that can wait for now.


Repository:
  rL LLVM

https://reviews.llvm.org/D28949





More information about the llvm-commits mailing list