[PATCH] D28949: [InstCombine][SSE] Add support for PACKSS/PACKUS constant folding

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:532
+  unsigned DstScalarSizeInBits = ResTy->getScalarSizeInBits();
+  unsigned SrcScalarSizeInBits = ArgTy->getScalarSizeInBits();
+  assert(SrcScalarSizeInBits == (2 * DstScalarSizeInBits) &&
----------------
SrcScalarSizeInBits is unused in release builds.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:539
+  auto *Cst1 = dyn_cast<Constant>(Arg1);
+  if (Cst0 && Cst1) {
+    SmallVector<Constant *, 32> Vals;
----------------
Can you reverse this if as an early out?


Repository:
  rL LLVM

https://reviews.llvm.org/D28949