[llvm] r292550 - [MIRParser] Allow generic register specification on operand.

[Ahmed Bougacha via llvm-commits]

Author: ab
Date: Thu Jan 19 18:29:59 2017
New Revision: 292550

URL: http://llvm.org/viewvc/llvm-project?rev=292550&view=rev
Log:
[MIRParser] Allow generic register specification on operand.

This completes r292321 by adding support for generic registers, e.g.:

  %2:_(s32) = G_ADD %0, %1

Modified:
    llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp
    llvm/trunk/test/CodeGen/MIR/X86/register-operand-class.mir

Modified: llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp?rev=292550&r1=292549&r2=292550&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp (original)
+++ llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp Thu Jan 19 18:29:59 2017
@@ -883,8 +883,8 @@ bool MIParser::parseRegister(unsigned &R
 }
 
 bool MIParser::parseRegisterClassOrBank(VRegInfo &RegInfo) {
-  if (Token.isNot(MIToken::Identifier))
-    return error("expected a register class or register bank name");
+  if (Token.isNot(MIToken::Identifier) && Token.isNot(MIToken::underscore))
+    return error("expected '_', register class, or register bank name");
   StringRef::iterator Loc = Token.location();
   StringRef Name = Token.stringValue();
 
@@ -914,26 +914,30 @@ bool MIParser::parseRegisterClassOrBank(
     llvm_unreachable("Unexpected register kind");
   }
 
-  // Should be a register bank.
-  auto RBNameI = PFS.Names2RegBanks.find(Name);
+  // Should be a register bank or a generic register.
+  const RegisterBank *RegBank = nullptr;
+  if (Name != "_") {
+    auto RBNameI = PFS.Names2RegBanks.find(Name);
+    if (RBNameI == PFS.Names2RegBanks.end())
+      return error(Loc, "expected '_', register class, or register bank name");
+    RegBank = RBNameI->getValue();
+  }
+
   lex();
-  if (RBNameI == PFS.Names2RegBanks.end())
-    return error(Loc, "expected a register class or register bank name");
 
-  const RegisterBank &RegBank = *RBNameI->getValue();
   switch (RegInfo.Kind) {
   case VRegInfo::UNKNOWN:
   case VRegInfo::GENERIC:
   case VRegInfo::REGBANK:
-    RegInfo.Kind = VRegInfo::REGBANK;
-    if (RegInfo.Explicit && RegInfo.D.RegBank != &RegBank)
-      return error(Loc, "conflicting register banks");
-    RegInfo.D.RegBank = &RegBank;
+    RegInfo.Kind = RegBank ? VRegInfo::REGBANK : VRegInfo::GENERIC;
+    if (RegInfo.Explicit && RegInfo.D.RegBank != RegBank)
+      return error(Loc, "conflicting generic register banks");
+    RegInfo.D.RegBank = RegBank;
     RegInfo.Explicit = true;
     return false;
 
   case VRegInfo::NORMAL:
-    return error(Loc, "register class specification on normal register");
+    return error(Loc, "register bank specification on normal register");
   }
   llvm_unreachable("Unexpected register kind");
 }

Modified: llvm/trunk/test/CodeGen/MIR/X86/register-operand-class.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/MIR/X86/register-operand-class.mir?rev=292550&r1=292549&r2=292550&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/MIR/X86/register-operand-class.mir (original)
+++ llvm/trunk/test/CodeGen/MIR/X86/register-operand-class.mir Thu Jan 19 18:29:59 2017
@@ -10,6 +10,7 @@
 # CHECK:   - { id: 1, class: gr64 }
 # CHECK:   - { id: 2, class: gr32 }
 # CHECK:   - { id: 3, class: gr16 }
+# CHECK:   - { id: 4, class: _ }
 name: func
 body: |
   bb.0:
@@ -21,4 +22,6 @@ body: |
 
     %3 : gr16 = COPY %bx
     %bx = COPY %3 : gr16
+
+    %4 : _(s32) = COPY %edx
 ...