[PATCH] D28596: [compiler-rt] General definition for weak functions.

[Mike Aizatsky via Phabricator via llvm-commits]

aizatsky requested changes to this revision.
aizatsky added a comment.
This revision now requires changes to proceed.

I don't like that we introduce macros making function definition ugly and opaque. All this to implement one platform hacks. I would prefer to have current version cleaned up to eliminate ifdefs. Something like:

  SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE
  const char *__ubsan_default_options() { return ""; }
  
  WIN_WEAK_FN(__ubsan_default_options);

Is such clenup possible? What properties does proposed solution have that cleanup one doesn't?


https://reviews.llvm.org/D28596