[PATCH] D28596: [compiler-rt] General definition for weak functions.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 16:03:41 PST 2017


mpividori updated this revision to Diff 84761.
mpividori added a comment.

@rnk  I updated the diff to add suggested changes. Would you agree? (In future, if we have link errors with weak symbols we must remember to use WIN_FORCE_LINK() to force linking to the object defining a weak symbol, but now, fortunately, it is not necessary, since weak symbols are defined in modules that define other non-weak symbols, so they are always included by the linker).


https://reviews.llvm.org/D28596

Files:
  lib/asan/asan_allocator.cc
  lib/asan/asan_flags.cc
  lib/asan/asan_interface_internal.h
  lib/asan/asan_report.cc
  lib/asan/asan_suppressions.cc
  lib/asan/asan_win.cc
  lib/sanitizer_common/sancov_flags.h
  lib/sanitizer_common/sanitizer_allocator_interface.h
  lib/sanitizer_common/sanitizer_common.cc
  lib/sanitizer_common/sanitizer_coverage_libcdep.cc
  lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc
  lib/sanitizer_common/sanitizer_interface_internal.h
  lib/sanitizer_common/sanitizer_internal_defs.h
  lib/sanitizer_common/sanitizer_printf.cc
  lib/sanitizer_common/sanitizer_win.cc
  lib/ubsan/ubsan_flags.cc
  lib/ubsan/ubsan_flags.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28596.84761.patch
Type: text/x-patch
Size: 16310 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170118/a692c31f/attachment.bin>


More information about the llvm-commits mailing list