[PATCH] D28256: AMDGPU: Skip fneg/select combine if it can fold into other

[Matt Arsenault via Phabricator via llvm-commits]

arsenm closed this revision.
arsenm added a comment.

r291792



================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:2763
+    // Careful: if the neg can be folded up, don't try to pull it back down.
+    bool ShouldFoldNeg = true;
 
----------------
nhaehnle wrote:
> Just ShouldFold, since it also refers to the fabs case?
This specifically is taking care of the -|x|, K case so it's more concerned about the negation


https://reviews.llvm.org/D28256