[PATCH] D28256: AMDGPU: Skip fneg/select combine if it can fold into other

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a reviewer: nhaehnle.
nhaehnle added a comment.
This revision is now accepted and ready to land.

One minor comment, LGTM otherwise.



================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:2763
+    // Careful: if the neg can be folded up, don't try to pull it back down.
+    bool ShouldFoldNeg = true;
 
----------------
Just ShouldFold, since it also refers to the fabs case?


https://reviews.llvm.org/D28256