[PATCH] D28556: [CodeGen] Rename MachineInstrBuilder::addOperand
Diana Picus via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 11 23:46:48 PST 2017
rovka added a comment.
Thanks for reviewing all of these!
In https://reviews.llvm.org/D28556#642942, @MatzeB wrote:
> BTW: You should append a "; NFC" to the title of this commit and the others of the series.
Ok. I wasn't sure if they're NFC, because they could break the build for downstream users (e.g. out-of-tree backends that use addOperand).
In https://reviews.llvm.org/D28556#643044, @arsenm wrote:
> Can you wait until after the branch to commit this?
Sure, I'll keep an eye out for that.
https://reviews.llvm.org/D28556
More information about the llvm-commits
mailing list