[PATCH] D28159: [ARM] Fix test CodeGen/ARM/fpcmp_ueq.ll broken by rL290616

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 11 04:07:08 PST 2017


rengolin added a comment.

In https://reviews.llvm.org/D28159#642532, @eastig wrote:

> The main reason for omitting the function names is that they are specific to FP ABI of a system. ' ___eqsf2' and '___unordsf2' are gcc soft float library functions. I am not an expert in Darwin which is used in the triple. As Darwin is based on BSD we might assume the same functions are always used on it. Can we?


Whatever LLVM outputs there should be correct for Apple. If they use the same functions, then you should write them down in the tests.

I think that the reason the names are not in there is that one doesn't depend on the other's arguments, so they could potentially come in different order.

One way to avoid that is to use `CHECK-DAG` just for the two `bl` calls, and keeping the rest as you wrote.

cheers,
--renato


https://reviews.llvm.org/D28159





More information about the llvm-commits mailing list