[PATCH] D28159: [ARM] Fix test CodeGen/ARM/fpcmp_ueq.ll broken by rL290616
Evgeny Astigeevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 11 03:46:38 PST 2017
eastig added a comment.
Hi Renato,
Thank for looking at the patch.
The main reason for omitting the function names is that they are specific to FP ABI of a system. ' ___eqsf2' and '___unordsf2' are gcc soft float library functions. I am not an expert in Darwin which is used in the triple. As Darwin is based on BSD we might assume the same functions are always used on it. Can we?
Another option is to add comments to the naked BLs explaining what can be there.
I prefer to have the function names in the checks.
Thanks,
Evgeny
https://reviews.llvm.org/D28159
More information about the llvm-commits
mailing list