[PATCH] D28459: Make processing @llvm.assume more efficient - Add affected values to the assumption cache

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 18:39:40 PST 2017


hfinkel added a comment.

In https://reviews.llvm.org/D28459#642239, @davide wrote:

> In https://reviews.llvm.org/D28459#642235, @davide wrote:
>
> > Sorry for the delay, Hal.
> >  I just checked and this doesn't regress the cases your previous change regressed, so we should be good on that side.
> >  I somehow share Dan's feeling that this could be solved with an infrastructural changes rather than caching, but I don't feel to be in a position to hinder progress without a concrete/implemented alternative.
>
>
> For those wondering, I mean http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170102/416193.html


@dberlin , @chandlerc , et al. does anyone object to me committing this solution at this point? I'm obviously happy to help replace it later with something based on an extended SSA form once we figure out how that should work. In the mean time, this fixes the compile-time problems, which users are certainly hitting, in a fairly transparent way.


https://reviews.llvm.org/D28459





More information about the llvm-commits mailing list