[PATCH] D28522: Codegen: Make chains from lattice-shaped CFGs

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:624
+      if (Successors.size() > 1
+          && hasSameSuccessors(*Pred, Successors))
+        // This looks like a tail-duplicated block. Skip it.
----------------
Is it better to relax the condition such that as long as Succ can be dup'd into one of the unplaced predecessors, return true?


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:630
+        // | \          | \
+        // |  C         |  C
+        // | /          |  |
----------------
Change the second 'C' to  'C (+ BB') ' where BB' is the dup of BB


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:633
+        // |/           |  |
+        // B     =>     B  |
+        // |\           |\/|
----------------
Better change 'B' to 'BB' to match the function argument name


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:639
+        // |/           |/
+        // E            E
+        //
----------------
Change E to 'Succ'


Repository:
  rL LLVM

https://reviews.llvm.org/D28522