[PATCH] D28369: Refactor inline threshold update code.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 15:25:04 PST 2017


davidxl added a comment.

Should we honor optForMinSize for HotCallsite case as well?

I also suggest split the source hint based check from the profile driven check.  Also check hotcallsite first:

if (!Caller->optForMinSize() ) {

  if (...InlineHint)
    Threshold = MaxIfValid (...);
  
  if (HotCallsite)
     ...
  else if (HotCallee) 
    ..

}


https://reviews.llvm.org/D28369





More information about the llvm-commits mailing list