[PATCH] D28369: Refactor inline threshold update code. NFC.
Easwaran Raman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 6 15:18:51 PST 2017
eraman added a comment.
In https://reviews.llvm.org/D28369#638375, @davidxl wrote:
> There is a slight difference here. In the old code, for hot callsite to hot callee, the threshold is max of (origthreshold, HintThreshold, HotCallSiteThreshold). With the new change, it becomes max (original_threshold, HotCallSiteThreshold).
Good catch! But I'll leave the patch as it is (except the NFC in the title) since the whole point is to move away from using hotness of callee to hotness of callsite. Also, this will have no impact with the default values since HotCallSiteThreshold >> HintThreshold.
https://reviews.llvm.org/D28369
More information about the llvm-commits
mailing list